Fix - Avoid SQL warning when no user session is active during plugin init by RomainLvr · Pull Request #1179 · pluginsGLPI/fields

RomainLvr · 2026-04-13T09:24:06Z

Checklist before requesting a review

Please delete options that are not relevant.

I have performed a self-review of my code.
I have added tests (when available) that prove my fix is effective or that my feature works.
I have updated the CHANGELOG with a short functional description of the fix or new feature.
This change requires a documentation update.

Description

It fixes !43370
Here is a brief description of what this PR does

When initializing the plugin during boot (before any user session), getEntitiesRestrictCriteria() was called without an active session, producing entities_id = '' in the SQL query and triggering a mass MySQL warning (1292: Truncated incorrect DECIMAL value).

Fix by skipping entity restriction when no user is logged in (!Session::getLoginUserID()), consistent with the existing check already in place in setup.php.

Error :

SQL: SELECT * FROM `glpi_plugin_fields_containers` WHERE `is_active` = '1' AND `type` = 'dom' AND ((`itemtypes` LIKE '%\\\"Ticket\\\"%') OR (`itemtypes` LIKE '%\\\"Change\\\"%') OR (`itemtypes` LIKE '%\\\"Problem\\\"%')) AND (`glpi_plugin_fields_containers`.`entities_id` = '') ORDER BY `name`
  Warnings: 
1292: Truncated incorrect DECIMAL value: '' at DBmysql.php line 444
  Backtrace :
  ./src/DBmysql.php:444                              
  ./src/DBmysqlIterator.php:129                      DBmysql->doQuery()
  ./src/DBmysql.php:1088                             DBmysqlIterator->execute()
  ./src/CommonDBTM.php:632                           DBmysql->request()
  ./plugins/fields/inc/questiontype.class.php:384    CommonDBTM->find()
  ./plugins/fields/inc/questiontype.class.php:426    PluginFieldsQuestionType->getAvailableBlocks()
  ./plugins/fields/setup.php:428                     PluginFieldsQuestionType::hasAvailableFields()
  ./plugins/fields/setup.php:136                     plugin_fields_register_plugin_types()
  ./src/Plugin.php:475                               plugin_init_fields()
  ./src/Plugin.php:428                               Plugin::load()
  ...tener/PostBootListener/InitializePlugins.php:75 Plugin->init()
  .../event-dispatcher/Debug/WrappedListener.php:116 Glpi\Kernel\Listener\PostBootListener\InitializePlugins->onPostBoot()
  ...ymfony/event-dispatcher/EventDispatcher.php:220 Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke()
  ...symfony/event-dispatcher/EventDispatcher.php:56 Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
  ...spatcher/Debug/TraceableEventDispatcher.php:142 Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
  ./src/Glpi/Kernel/Kernel.php:149                   Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch()
  ./vendor/symfony/http-kernel/Kernel.php:201        Glpi\Kernel\Kernel->boot()
  ./public/index.php:71                              Symfony\Component\HttpKernel\Kernel->handle()

Close #1172

…init

Rom1-B · 2026-04-15T10:24:00Z

        $entity_restrict = isCommandLine() ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true);
+
+        // If entity restriction contains an empty string value, it means no valid session
+        // is active. Running the query would produce a MySQL
+        // warning (1292: Truncated incorrect DECIMAL value)
+        foreach ($entity_restrict as $criterion) {
+            if (is_array($criterion) && in_array('', $criterion, true)) {
+                return $available_blocks;
+            }
+        }
+


Maybe something like this:

Suggested change

$entity_restrict = isCommandLine() ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true);

// If entity restriction contains an empty string value, it means no valid session

// is active. Running the query would produce a MySQL

// warning (1292: Truncated incorrect DECIMAL value)

foreach ($entity_restrict as $criterion) {

if (is_array($criterion) && in_array('', $criterion, true)) {

return $available_blocks;

}

}

$activeentities = getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true);

if ($activeentities === []) {

return [];

}

$entity_restrict = isCommandLine() ? [] : $activeentities;

getEntitiesRestrictCriteria returns an array of criteria. The problem here isn't that getEntitiesRestrictCriteria returns an empty array; rather, it returns the criterion glpi_plugin_fields_containers.entities_id = "", so the suggestion won't fix the problem.

That's true, but ultimately I think the problem lies in the getEntitiesRestrictCriteria() function, which returns an invalid value. Instead of returning ...entities_id = '' (which can never work), it should return [new QueryExpression(‘false’)];
For your information, it also checks isCommandLine(), so the one here will likely be redundant.

You're right, the root cause is actually in the GLPI core — DbUtils::getEntitiesRestrictCriteria() in DbUtils.php.

When called with no active session, no CLI context, and no cron context, the function falls through all conditions without an else branch, leaving $value as an empty string ''. This produces an invalid SQL criterion entities_id = '' on an integer column, which triggers MySQL warning.

I've updated this with a cleaner guard:

if (!Session::getLoginUserID() && !isCommandLine()) { return $available_blocks; }

This is semantically explicit (no session = no available blocks), consistent with the existing guard already in place in setup.php l.138 — it doesn't rely on inspecting the internal structure of the criteria returned by core.

The real fix should live in the core: adding an else { return [new QueryExpression('false')]; } branch to getEntitiesRestrictCriteria() so all callers are protected. I'll open a separate PR on the GLPI core for that.

here is the fix for the core : glpi-project/glpi#23934

RomainLvr added 2 commits April 13, 2026 11:19

Fix - Avoid SQL warning when no user session is active during plugin …

b882743

…init

Update CHANGELOG

ecf1c25

Rom1-B requested changes Apr 13, 2026

View reviewed changes

Comment thread inc/questiontype.class.php Outdated

Apply suggestions

24404ce

RomainLvr requested a review from Rom1-B April 15, 2026 09:45

Rom1-B reviewed Apr 15, 2026

View reviewed changes

Merge branch 'main' into fix/entity-restrict-criteria-without-session

0c7557b

RomainLvr requested a review from Rom1-B April 15, 2026 15:27

Apply suggestions

8e82d36

RomainLvr mentioned this pull request Apr 16, 2026

Fix - getEntitiesRestrictCriteria() returns invalid SQL criterion when no session is active glpi-project/glpi#23934

Merged

4 tasks

Rom1-B approved these changes Apr 16, 2026

View reviewed changes

Rom1-B merged commit 74f09a8 into main Apr 16, 2026
3 checks passed

Rom1-B deleted the fix/entity-restrict-criteria-without-session branch April 16, 2026 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - Avoid SQL warning when no user session is active during plugin init#1179

Fix - Avoid SQL warning when no user session is active during plugin init#1179
Rom1-B merged 5 commits intomainfrom
fix/entity-restrict-criteria-without-session

RomainLvr commented Apr 13, 2026

Uh oh!

Uh oh!

Rom1-B Apr 15, 2026

Uh oh!

RomainLvr Apr 15, 2026

Uh oh!

Rom1-B Apr 16, 2026 •

edited

Loading

Uh oh!

RomainLvr Apr 16, 2026

Uh oh!

RomainLvr Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

RomainLvr commented Apr 13, 2026

Checklist before requesting a review

Description

Uh oh!

Uh oh!

Rom1-B Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

RomainLvr Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Rom1-B Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RomainLvr Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

RomainLvr Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rom1-B Apr 16, 2026 •

edited

Loading